Skip to content

Conversation

@nordic-auko
Copy link
Contributor

Fix indexing variable mismatch.

Copy link
Contributor

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to make the commit the fixup for fac7ac4?

@nvlsianpu nvlsianpu added backport ncs-v3.1-branch backport PR for NCS 3.1.x release bugfix Fixes a known bug labels Aug 6, 2025
@nordic-auko
Copy link
Contributor Author

Would it be possible to make the commit the fixup for fac7ac4?

Good question. That would require a force push to main?

@de-nordic
Copy link
Contributor

Would it be possible to make the commit the fixup for fac7ac4?

Good question. That would require a force push to main?

Yes but we do that from time to time. We rebase the main on upmerges and then fixups are squashed together.

nrf-squash! [nrf noup] boot/zephyr/nrf_cleanup: cleanup uarte pins

Fix indexing variable mismatch.

Signed-off-by: Audun Korneliussen <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

@nordic-auko
Copy link
Contributor Author

Would it be possible to make the commit the fixup for fac7ac4?

Good question. That would require a force push to main?

Yes but we do that from time to time. We rebase the main on upmerges and then fixups are squashed together.

Done

@nvlsianpu nvlsianpu merged commit 58175b6 into nrfconnect:main Aug 7, 2025
2 checks passed
@nordic-auko nordic-auko deleted the nrf-cleanup-fix branch August 8, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport ncs-v3.1-branch backport PR for NCS 3.1.x release bugfix Fixes a known bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants